Merged
Conversation
factory-nizar
force-pushed
the
feat/code-review-skill
branch
from
275dbf1 to
695c6d6
Compare
Adds a review skill that can be invoked by humans in TUI sessions and by models programmatically. Provides a structured review methodology with bug patterns, analysis discipline, and reporting gates. Shared methodology is marked with BEGIN/END_SHARED_METHODOLOGY so the CI action can extract just the methodology for deep review prompts. TUI path returns findings locally; CI path posts PR comments. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
factory-nizar
force-pushed
the
feat/code-review-skill
branch
from
695c6d6 to
51dbc45
Compare
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
factory-nizar
commented
Mar 23, 2026
README.md
Outdated
| **Skills:** | ||
|
|
||
| - `review` - Review code changes and identify high-confidence, actionable bugs. Includes systematic analysis patterns for null safety, async/await, security, concurrency, API contracts, and more. Used by both the CLI `/review` command and the CI action. | ||
| - `session-navigation` - Search and navigate past Droid sessions |
Contributor
Author
There was a problem hiding this comment.
noticed these were missing, not sure if we should add or we omitted intentionally
factory-nizar
commented
Mar 23, 2026
| 2. **Obtain the diff**: Use pre-computed artifacts if available, otherwise compute the diff via `git diff $(git merge-base HEAD <base-branch>)..HEAD`. | ||
| 3. **Review all changed files**: Do not skip any file. Work through the diff methodically. | ||
|
|
||
| <!-- BEGIN_SHARED_METHODOLOGY --> |
Contributor
Author
There was a problem hiding this comment.
alternatively could also split the files, i think this might evolve as I determine how different the prompts are for deep vs shallow but currently the only difference is posting comments.
Contributor
There was a problem hiding this comment.
Single file seems reasonable until we get a sense of cost dynamics
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Include candidate generation (file grouping, parallel subagents, aggregation) and validation (confidence-based filtering, strict deduplication) in SKILL.md. This makes the skill the single source of truth for the review process, used by both the CLI /review command and the CI action. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
factory-nizar
changed the title
jonathan-factory
approved these changes
Mar 24, 2026
Contributor
jonathan-factory
left a comment
jonathan-factory
left a comment
There was a problem hiding this comment.
Looks good, @factory-arman heads up that we're moving the review prompt from the droid-action repo to a core plugin skill
Will allow us to reuse the same review logic in /review, the droid-action CI job and in interactive mode when the user prompts for a review
jonathan-factory
approved these changes
Mar 24, 2026
| 2. **Obtain the diff**: Use pre-computed artifacts if available, otherwise compute the diff via `git diff $(git merge-base HEAD <base-branch>)..HEAD`. | ||
| 3. **Review all changed files**: Do not skip any file. Work through the diff methodically. | ||
|
|
||
| <!-- BEGIN_SHARED_METHODOLOGY --> |
Contributor
There was a problem hiding this comment.
Single file seems reasonable until we get a sense of cost dynamics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
reviewskill to the core plugin atplugins/core/skills/review/SKILL.md. This is the canonical source of truth for the review methodology, used by both the CLI/reviewcommand and the CI action.What the Skill Contains
Shared Methodology (between
<!-- BEGIN/END_SHARED_METHODOLOGY -->markers)Two-Pass Review Pipeline
README
coreplugin section documenting thereviewskill